fix: decimal precision/scale for fuzz #3266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert3005
approved these changes
May 9, 2025
a10y
force-pushed
the
aduffy/arbitrary-decimal
branch
from
a050404 to
570130f
Compare
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
a10y
force-pushed
the
aduffy/arbitrary-decimal
branch
from
570130f to
fa39121
Compare
joseph-isaacs
approved these changes
May 9, 2025
Contributor
joseph-isaacs
left a comment
joseph-isaacs
left a comment
There was a problem hiding this comment.
What not fuzz decimal 256
vortex-dtype/src/arbitrary.rs
Outdated
| // Get a random integer for the scale | ||
| let precision = u8::try_from(u.int_in_range(0..=38)?).expect("u8 overflow"); | ||
| let scale = i8::try_from(u.int_in_range(-38..=38)?).expect("i8 overflow"); | ||
| let precision = u8::try_from(u.int_in_range(1..=38)?).expect("u8 overflow"); |
Contributor
There was a problem hiding this comment.
Suggested change
| let precision = u8::try_from(u.int_in_range(1..=38)?).expect("u8 overflow"); | |
| let precision = u8::try_from(u.int_in_range(1..=MAX_PRECISION)?).expect("u8 overflow"); |
Contributor
Author
|
Yea we can, need to also fix scalar generation logic too to distinguish |
Contributor
Author
|
One sec |
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
a10y
force-pushed
the
aduffy/arbitrary-decimal
branch
from
fc217eb to
6d77334
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.