chore: TakeKernel for List
#3750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
50
to
58
| for &idx in indices { | ||
| let idx = idx | ||
| .to_usize() | ||
| .ok_or_else(|| vortex_err!("Failed to convert index to usize: {}", idx))?; | ||
|
|
||
| let elem = array.scalar_at(idx)?; | ||
| builder.append_value(elem.as_list())?; | ||
| } | ||
| Ok(builder.finish()) |
Contributor
There was a problem hiding this comment.
can we not implement this using a take on the elements?
Contributor
There was a problem hiding this comment.
scalar at is very slow
Member
Author
There was a problem hiding this comment.
great idea, should we faster now 🙌🏻
blaginin
force-pushed
the
db/take-for-array
branch
from
7e9ce5f to
6ac29aa
Compare
blaginin
force-pushed
the
db/take-for-array
branch
from
1404dbf to
0034dfe
Compare
Signed-off-by: blaginin <dima@spiraldb.com>
blaginin
force-pushed
the
db/take-for-array
branch
from
3a4b5d3 to
082dcc6
Compare
robert3005
reviewed
Jul 4, 2025
| let elements_to_take = elements_to_take.finish(); | ||
| let new_offsets = new_offsets.finish(); | ||
|
|
||
| let new_elements = crate::compute::take(array.elements(), elements_to_take.as_ref())?; |
robert3005
reviewed
Jul 4, 2025
|
|
||
| let mut current_offset = O::zero(); | ||
| new_offsets.append_zero(); | ||
| let mut new_validity = BoolBuilder::with_capacity(Nullability::NonNullable, 2 * indices.len()); |
Contributor
There was a problem hiding this comment.
Since we are building validity here I would use arrow's BooleanBufferBuilder
robert3005
reviewed
Jul 4, 2025
| let new_offsets = new_offsets.finish(); | ||
| let new_elements = crate::compute::take(array.elements(), elements_to_take.as_ref())?; | ||
|
|
||
| let new_validity: Validity = Validity::Array(new_validity.finish()); |
Contributor
There was a problem hiding this comment.
Then this is just Validitity::from(new_validity.finish())
Signed-off-by: blaginin <dima@spiraldb.com>
Signed-off-by: blaginin <dima@spiraldb.com>
robert3005
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very similar to https://github.com/vortex-data/vortex/blob/develop/vortex-array/src/arrays/varbin/compute/take.rs but annoyingly can't unify