Generalize expression partition to annotationed expressions #3803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
| .entry(node) | ||
| .or_default() | ||
| .extend(annotations); | ||
| Ok(TraversalOrder::Skip) |
Contributor
There was a problem hiding this comment.
I find this unexpected from the name of the visitor
Contributor
There was a problem hiding this comment.
I would expect annotate to either continue down or return a TraversalOrder here
Contributor
There was a problem hiding this comment.
This is refactoring of the previous logic where we would always continue on empty annotations and skip immediately when we had one present
Contributor
There was a problem hiding this comment.
That is not true, this has been generalised
Contributor
Author
There was a problem hiding this comment.
Yeah it's perhaps a little odd to skip at the first sign of an annotation..
Signed-off-by: Nicholas Gates <nick@nickgates.com>
robert3005
previously approved these changes
Jul 9, 2025
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
gatesn
changed the title
Contributor
Contributor
Benchmarks: TPC-H on NVMETable of Results
|
Contributor
Benchmarks: TPC-H on S3Table of Results
|
Contributor
Benchmarks: compressTable of Results
|
robert3005
approved these changes
Jul 9, 2025
Contributor
Benchmarks: Clickbench on NVMETable of Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, expression partitioning only worked for fields accessed on the root scope. This change allows an expression to be partitioned by an arbitrary set of annotations.
This means custom expressions can be grouped into a partition and pulled out separately from the rest.