chore[bench]: have --skip-generate option and only create iterators for tpch when needed
#4328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen needed Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
changed the title
--skip_generate option and only create iterators for tpch when needed--skip-generate option and only create iterators for tpch when needed
…hen needed Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
gatesn
reviewed
Aug 22, 2025
|
|
||
| /// Run a benchmark using the provided implementation and configuration | ||
| pub fn run_benchmark<B: Benchmark>(benchmark: B, config: DriverConfig) -> Result<()> { | ||
| // Generate data for each target (idempotent) |
Contributor
There was a problem hiding this comment.
So was it not idempotent before?
Contributor
Author
There was a problem hiding this comment.
it was, the file was not rewritten, but lots of extra work was gone and then not done
Contributor
Author
There was a problem hiding this comment.
this just allow a future escape hatch
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Benchmarks: TPC-H SF=1 on NVMETable of Results
|
gatesn
approved these changes
Aug 22, 2025
Contributor
Benchmarks: TPC-H SF=1 on S3Table of Results
|
Unable to generate the performance reportThere was an internal error while processing the run's data. We're working on fixing the issue. Feel free to contact us on Discord or at support@codspeed.io if the issue persists. |
Contributor
Benchmarks: compressTable of Results
|
Contributor
Benchmarks: Clickbench on NVMETable of Results
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMETable of Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.