Skip to content

Conversation

@AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Sep 30, 2025

I blame rust for making me disable autosave. Originally introduced in #4795

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS requested a review from robert3005 September 30, 2025 16:16
@AdamGS AdamGS added the chore Release label indicating a trivial change label Sep 30, 2025
@AdamGS AdamGS enabled auto-merge (squash) September 30, 2025 16:16
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 30, 2025

CodSpeed Performance Report

Merging #4796 will improve performances by 13.43%

Comparing adamg/fix-parca-config-leftover (0d05435) with develop (02f4228)1

Summary

⚡ 3 improvements
✅ 1153 untouched

Benchmarks breakdown

Benchmark BASE HEAD Change
take_map[(0.05, 1.0)] 552.8 µs 487.3 µs +13.43%
take_map[(0.1, 0.5)] 355.1 µs 321.8 µs +10.35%
take_map[(0.1, 1.0)] 624.3 µs 563 µs +10.89%

Footnotes

  1. No successful run was found on develop (2570385) during the generation of this report, so 02f4228 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@AdamGS AdamGS merged commit 562443f into develop Sep 30, 2025
39 of 40 checks passed
@AdamGS AdamGS deleted the adamg/fix-parca-config-leftover branch September 30, 2025 16:26
@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.55%. Comparing base (2570385) to head (0d05435).
⚠️ Report is 1 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Release label indicating a trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants