Skip to content

Chore: clean up vectors more #5040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
connortsui20 wants to merge 3 commits into from
Closed

Chore: clean up vectors more #5040

connortsui20 wants to merge 3 commits into from

Conversation

@connortsui20
Copy link
Contributor

@connortsui20 connortsui20 commented Oct 22, 2025 •
edited
Loading

Cleans up some things in the crate (this is a purely cosmetic change)

@connortsui20 connortsui20 requested a review from gatesn October 22, 2025 21:53
@connortsui20 connortsui20 added the chore Release label indicating a trivial change label Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.52%. Comparing base (469b801) to head (1268de7).
⚠️ Report is 6 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gatesn
gatesn requested changes Oct 22, 2025
View reviewed changes
@connortsui20 connortsui20 mentioned this pull request Oct 23, 2025
Closed
@connortsui20 connortsui20 changed the base branch from ct/vector-cleanup-more to develop October 23, 2025 13:57
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 23, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #5040 will not alter performance

Comparing ct/vv-trusted-len (1268de7) with develop (469b801)

Summary

✅ 1309 untouched

@connortsui20 connortsui20 changed the title Chore: Add trusted len constructors Chore: clean up vectors more Oct 23, 2025
@connortsui20 connortsui20 requested a review from gatesn October 23, 2025 20:12
@connortsui20
un-export macros
6a50db1 
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20
add from_iter.rs files
80eb5a3 
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20
even more docs
1268de7 
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20
Copy link
Contributor Author

connortsui20 commented Oct 23, 2025

This PR no longer has anything to do with trusted length iterators

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 24, 2025

Deploying vortex-bench with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1268de7
Status: ✅  Deploy successful!
Preview URL: https://96c119c8.vortex-93b.pages.dev
Branch Preview URL: https://ct-vv-move-around.vortex-93b.pages.dev

View logs

@connortsui20 connortsui20 mentioned this pull request Oct 24, 2025
Merged
robert3005 pushed a commit that referenced this pull request Oct 24, 2025
@connortsui20
Chore: Move stuff around in vectors (#5072)
3fcccdb 
Resurrected from #5040

This is a purely cosmetic change

---------

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 deleted the ct/vv-trusted-len branch October 24, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gatesn gatesn Awaiting requested review from gatesn

Assignees

No one assigned

Labels

chore Release label indicating a trivial change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@connortsui20 @gatesn