Skip to content

Conversation

@danking
Copy link
Contributor

@danking danking commented Nov 18, 2025

Resolves: #5364

As we gather less expert users, I think it's worthwhile to suggest to those users how to resolve a floating point mismatch error.

Signed-off-by: Daniel King <dan@spiraldb.com>
@danking danking requested review from a10y and gatesn November 18, 2025 22:16
@danking danking added the chore Release label indicating a trivial change label Nov 18, 2025
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 94.64286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.03%. Comparing base (1aac9ca) to head (875e506).
⚠️ Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-array/src/compute/compare.rs 94.64% 3 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danking danking marked this pull request as ready for review November 18, 2025 22:34
@danking danking merged commit e1c8435 into develop Nov 18, 2025
40 of 41 checks passed
@danking danking deleted the dk/better-compare-error branch November 18, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Release label indicating a trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type-invalid comparisons need a better error message

3 participants