Skip to content

Conversation

@joseph-isaacs
Copy link
Contributor

No description provided.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs added the chore Release label indicating a trivial change label Nov 19, 2025
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 86.87783% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.94%. Comparing base (63aa58c) to head (4ebada7).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-array/src/expr/transform/simplify_typed.rs 77.41% 14 Missing ⚠️
vortex-array/src/expr/session/rewrite.rs 88.00% 9 Missing ⚠️
vortex-array/src/expr/transform/simplify.rs 90.19% 5 Missing ⚠️
vortex-array/src/expr/transform/optimizer.rs 83.33% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@robert3005 robert3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) November 19, 2025 16:15
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 19, 2025

CodSpeed Performance Report

Merging #5401 will improve performances by 10.17%

Comparing ji/arc-rule-list (4ebada7) with develop (e25c0a2)

Summary

⚡ 1 improvement
✅ 1420 untouched
🆕 7 new
⏩ 680 skipped1
🗄️ 28 archived benchmarks run2

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 decompress[("alp_for_bp_f64", 0x4635aa0)] N/A 24.2 ms N/A
🆕 decompress[("datetime_for_bp", 0x4638960)] N/A 34.9 ms N/A
🆕 decompress[("dict_fsst_varbin_bp_string", 0x4637ca0)] N/A 14.5 ms N/A
🆕 decompress[("dict_fsst_varbin_string", 0x4637800)] N/A 14.5 ms N/A
🆕 decompress[("dict_varbinview_string", 0x46364c0)] N/A 14.7 ms N/A
🆕 decompress[("for_bp_u64", 0x4635350)] N/A 2.5 ms N/A
🆕 decompress[("runend_for_bp_u32", 0x4636950)] N/A 2 ms N/A
dict_compress_string 97.8 ms 88.8 ms +10.17%

Footnotes

  1. 680 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. 28 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them.

@joseph-isaacs joseph-isaacs merged commit 3df9296 into develop Nov 19, 2025
38 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/arc-rule-list branch November 19, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Release label indicating a trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants