Skip to content

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Dec 15, 2025

And...

  • Adds unary filter push-down rule
  • Fixes ordering of filter + project in layout reader

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the fix label Dec 15, 2025
@gatesn gatesn enabled auto-merge (squash) December 15, 2025 12:09
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 15, 2025

CodSpeed Performance Report

Merging #5731 will degrade performances by 10.74%

Comparing ngates/fix-filter-rules (8bdedcc) with develop (afe1196)

Summary

❌ 16 regressions
✅ 1240 untouched
⏩ 621 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
bench_dict_mask[(0.01, 0.1)] 1 ms 1.2 ms -10.73%
bench_dict_mask[(0.01, 0.01)] 1 ms 1.2 ms -10.74%
bench_dict_mask[(0.01, 0.9)] 1 ms 1.2 ms -10.73%
bench_dict_mask[(0.1, 0.01)] 1 ms 1.2 ms -10.74%
bench_dict_mask[(0.1, 0.5)] 1 ms 1.2 ms -10.74%
bench_dict_mask[(0.9, 0.01)] 1 ms 1.2 ms -10.74%
bench_dict_mask[(0.1, 0.1)] 1 ms 1.2 ms -10.73%
bench_dict_mask[(0.1, 0.9)] 1 ms 1.2 ms -10.73%
bench_dict_mask[(0.5, 0.1)] 1 ms 1.2 ms -10.73%
bench_dict_mask[(0.9, 0.9)] 1.1 ms 1.2 ms -10.7%
bench_dict_mask[(0.5, 0.9)] 1 ms 1.2 ms -10.73%
bench_dict_mask[(0.5, 0.01)] 1 ms 1.2 ms -10.74%
bench_dict_mask[(0.9, 0.5)] 1 ms 1.2 ms -10.74%
bench_dict_mask[(0.9, 0.1)] 1 ms 1.2 ms -10.73%
bench_dict_mask[(0.5, 0.5)] 1 ms 1.2 ms -10.74%
bench_dict_mask[(0.01, 0.5)] 1 ms 1.2 ms -10.73%

Footnotes

  1. 621 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.62%. Comparing base (1058e6d) to head (8bdedcc).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-array/src/arrays/scalar_fn/rules.rs 0.00% 30 Missing ⚠️
vortex-array/src/arrow/executor/struct_.rs 0.00% 7 Missing ⚠️
vortex-array/src/arrays/filter/array.rs 0.00% 1 Missing ⚠️
vortex-layout/src/layouts/flat/reader.rs 0.00% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gatesn gatesn merged commit 9a76489 into develop Dec 15, 2025
46 of 48 checks passed
@gatesn gatesn deleted the ngates/fix-filter-rules branch December 15, 2025 14:01
paultiq pushed a commit to paultiq/vortex that referenced this pull request Dec 17, 2025
And...
* Adds unary filter push-down rule
* Fixes ordering of filter + project in layout reader

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants