Skip to content

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Dec 19, 2025

No description provided.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 19, 2025

CodSpeed Performance Report

Merging #5804 will improve performances by 12%

Comparing ngates/cast-push-down (b97587b) with develop (d12f356)

Summary

⚡ 2 improvements
✅ 1252 untouched
⏩ 623 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Change
compress[(1000, 16)] 55.7 µs 50.2 µs +10.96%
compress[(1000, 256)] 51.4 µs 45.8 µs +12%

Footnotes

  1. 623 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.03%. Comparing base (d12f356) to head (b97587b).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-array/src/arrow/executor/list.rs 0.00% 16 Missing ⚠️
vortex-array/src/arrow/executor/mod.rs 0.00% 16 Missing ⚠️
vortex-array/src/arrays/struct_/vtable/rules.rs 0.00% 8 Missing ⚠️
vortex-array/src/arrow/executor/struct_.rs 0.00% 4 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gatesn gatesn added the fix label Dec 19, 2025
@gatesn gatesn enabled auto-merge (squash) December 19, 2025 15:08
@gatesn gatesn merged commit 155ca5b into develop Dec 19, 2025
47 of 48 checks passed
@gatesn gatesn deleted the ngates/cast-push-down branch December 19, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants