Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Andrew Duffy <andrew@a10y.dev> --- Your goal is to upgrade this repository to the latest Spark V4 release. There is a multi-project Gradle build inside of the @java folder, which currently targets Spark 3.5.7 Make any changes needed in the @java/vortex-spark subproject to allow us to start publishing a new JAR for Spark v4 Use Scala 2.12 We use the `com.palantir.consistent-versions` gradle plugin for managing dependencies using the @java/versions.props file to declare version pins. If you update a version pin or add/remove a dependency, run `./gradelw --write-locks` from inside of @java to update the `@java/versions.lock file Use the installed JDK from the environment to run Gradle. To run unit tests: ./gradlew vortex-spark:test All gradle commands should be run from inside the @java folder
robert3005
approved these changes
Jan 14, 2026
danking
pushed a commit
that referenced
this pull request
Feb 6, 2026
Tested using our existing unit tests. We could create a separate vortex-spark3 and vortex-spark4 repo if we really wanted to go the extra mile but I think that's not necessary until someone comes yelling about Spark 3 support. This switches our JARs to build for minimum Java 17 and Spark 4 deprecates support for Scala 2.12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested using our existing unit tests.
We could create a separate vortex-spark3 and vortex-spark4 repo if we really wanted to go the extra mile but I think that's not necessary until someone comes yelling about Spark 3 support.
This switches our JARs to build for minimum Java 17 and Spark 4 deprecates support for Scala 2.12