chore[btrblocks]: add scheme selection tests for all compression schemes#5953
Merged
joseph-isaacs merged 2 commits intodevelopfrom Jan 14, 2026
Merged
chore[btrblocks]: add scheme selection tests for all compression schemes#5953joseph-isaacs merged 2 commits intodevelopfrom
joseph-isaacs merged 2 commits intodevelopfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add tests to verify that each BtrBlocks compression scheme produces the expected encoding type when compressing specific data patterns. Integer schemes tested (8 tests): - ConstantVTable, FoRVTable, BitPackedVTable, SparseVTable - DictVTable, RunEndVTable, SequenceVTable, RLEVTable Float schemes tested (4 tests): - ConstantVTable, ALPVTable, DictVTable, SparseVTable (null-dominated) String schemes tested (3 tests): - ConstantVTable, DictVTable, FSSTVTable Signed-off-by: Joe Isaacs <joe@spiraldb.com> Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
joseph-isaacs
force-pushed
the
ji/btr-blocks-encoding-test
branch
from
a78d620 to
9ee74ac
Compare
joseph-isaacs
changed the title
joseph-isaacs
changed the title
robert3005
approved these changes
Jan 14, 2026
Contributor
robert3005
left a comment
robert3005
left a comment
There was a problem hiding this comment.
Those leading new lines are painful to see but test coverage here is good to have
danking
pushed a commit
that referenced
this pull request
Feb 6, 2026
…mes (#5953) Add comprehensive tests to verify that each BtrBlocks compression scheme is correctly selected when it provides the best compression for specific data patterns. This helps catch regressions where a scheme is never chosen. Integer schemes (9 tests): - ConstantScheme, FORScheme, ZigZagScheme, BitPackingScheme - SparseScheme, DictScheme, RunEndScheme, SequenceScheme, RLE Float schemes (9 tests): - ConstantScheme, ALPScheme, ALPRDScheme, DictScheme - NullDominated, RLE, UncompressedScheme fallback String schemes (7 tests): - ConstantScheme, DictScheme, FSSTScheme, NullDominated - UncompressedScheme fallback --------- Signed-off-by: Joe Isaacs <joe@spiraldb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive tests to verify that each BtrBlocks compression scheme is correctly selected when it provides the best compression for specific data patterns. This helps catch regressions where a scheme is never chosen.
Integer schemes (9 tests):
Float schemes (9 tests):
String schemes (7 tests):