Skip to content

Fix: pull out match statement#5986

Merged
connortsui20 merged 1 commit intodevelopfrom
ct/fix-struct-cmp
Jan 15, 2026
Merged

Fix: pull out match statement#5986
connortsui20 merged 1 commit intodevelopfrom
ct/fix-struct-cmp

Conversation

@connortsui20
Copy link
Copy Markdown
Contributor

follow up #5985

@connortsui20 connortsui20 requested a review from a10y January 15, 2026 20:42
@connortsui20 connortsui20 added the changelog/fix A bug fix label Jan 15, 2026
@connortsui20 connortsui20 enabled auto-merge (squash) January 15, 2026 20:42
@connortsui20 connortsui20 disabled auto-merge January 15, 2026 20:42
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 enabled auto-merge (squash) January 15, 2026 20:45
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 15, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing ct/fix-struct-cmp (69d8537) with develop (82edb54)

Summary

✅ 1254 untouched benchmarks
⏩ 1254 skipped benchmarks1

Footnotes

  1. 1254 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@connortsui20 connortsui20 merged commit 4bbafe7 into develop Jan 15, 2026
47 of 48 checks passed
@connortsui20 connortsui20 deleted the ct/fix-struct-cmp branch January 15, 2026 20:54
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.89%. Comparing base (82edb54) to head (69d8537).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-array/src/compute/compare.rs 55.55% 4 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

danking pushed a commit that referenced this pull request Feb 6, 2026
follow up #5985

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants