Skip to content

chore: return CUDA events from kernel launch#5993

Merged
0ax1 merged 4 commits intodevelopfrom
ad/proper-return-type
Jan 16, 2026
Merged

chore: return CUDA events from kernel launch#5993
0ax1 merged 4 commits intodevelopfrom
ad/proper-return-type

Conversation

@0ax1
Copy link
Copy Markdown
Contributor

@0ax1 0ax1 commented Jan 16, 2026

This PR changes the launch kernel API in vortex-cuda to propagate the pair of CUDA events returned from cudarc::LaunchArgs:launch.

When launching a kernel, CUDAs events are automatically submitted before and after.
The events can be used to wait for a particular kernel to finish or to benchmark a CUDA kernel.

Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 added the changelog/chore A trivial change label Jan 16, 2026
@0ax1 0ax1 changed the title chore: CUDA kernels to return CUDA events chore: return CUDA events from kernel launch Jan 16, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 16, 2026

Merging this PR will not alter performance

✅ 1254 untouched benchmarks
⏩ 1254 skipped benchmarks1


Comparing ad/proper-return-type (1048b2e) with develop (86b3d02)

Open in CodSpeed

Footnotes

  1. 1254 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.87%. Comparing base (4bbafe7) to head (1048b2e).
⚠️ Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-cuda/src/executor.rs 0.00% 12 Missing ⚠️
vortex-cuda/src/for_.rs 0.00% 4 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

0ax1 added 2 commits January 16, 2026 11:03
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 enabled auto-merge (squash) January 16, 2026 11:21
Comment thread vortex-cuda/src/executor.rs Outdated
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 requested a review from gatesn January 16, 2026 11:55
@0ax1 0ax1 merged commit 49cf3aa into develop Jan 16, 2026
49 of 50 checks passed
@0ax1 0ax1 deleted the ad/proper-return-type branch January 16, 2026 12:38
danking pushed a commit that referenced this pull request Feb 6, 2026
This PR changes the launch kernel API in vortex-cuda to propagate the
pair of CUDA events returned from `cudarc::LaunchArgs:launch`.

When launching a kernel, CUDAs events are automatically submitted before and after. 
The events can be used to wait for a particular kernel to finish or to benchmark a CUDA kernel.

---------

Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants