Skip to content

Make prost a mandatory dependency of vortex-error #6059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AdamGS merged 1 commit into from
Jan 20, 2026
Merged

Make prost a mandatory dependency of vortex-error #6059

AdamGS merged 1 commit into from
Jan 20, 2026

Conversation

@AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Jan 20, 2026 •
edited
Loading

  1. Its already enabled by vortex-array, which basically everything will pull.
  2. Its unnecessarily avoided in vortex-scalar, which even more things pull.
  3. We really don't need three different variants here, surely one is enough.
  4. This has benefits in CI, just reducing the overall size of the internal dependency matrix.

@AdamGS
Make mandatory dependency of vortex-error
b708706 
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS added the chore Release label indicating a trivial change label Jan 20, 2026
@AdamGS AdamGS marked this pull request as ready for review January 20, 2026 15:13
@AdamGS AdamGS merged commit cd9048d into develop Jan 20, 2026
46 of 48 checks passed
@AdamGS AdamGS deleted the adamg/remove-prost-feature-error branch January 20, 2026 15:14
@AdamGS AdamGS mentioned this pull request Jan 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gatesn gatesn gatesn approved these changes

Assignees

No one assigned

Labels

chore Release label indicating a trivial change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AdamGS @gatesn