Skip to content

chore[cuda]: decimal_byte_parts#6118

Merged
joseph-isaacs merged 4 commits intodevelopfrom
ji/dbp-cuda
Jan 23, 2026
Merged

chore[cuda]: decimal_byte_parts#6118
joseph-isaacs merged 4 commits intodevelopfrom
ji/dbp-cuda

Conversation

@joseph-isaacs
Copy link
Contributor

No description provided.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs requested a review from 0ax1 January 23, 2026 11:16
@joseph-isaacs joseph-isaacs added the changelog/feature A new feature label Jan 23, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 23, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 39.81%

Comparing ji/dbp-cuda (9760e67) with develop (9c6399a)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 5 improved benchmarks
❌ 10 regressed benchmarks
✅ 1259 untouched benchmarks
⏩ 1254 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime u16_FoR[10M] 11 µs 6.4 µs +72.15%
WallTime u32_FoR[1K] 7 µs 6 µs +16.15%
WallTime u8_FoR[10K] 5.7 µs 7 µs -17.59%
WallTime u32_FoR[10K] 6.3 µs 7.7 µs -18.7%
WallTime u64_FoR[10K] 8.2 µs 13.7 µs -39.81%
WallTime u8_FoR[10M] 6.4 µs 5.7 µs +13.02%
Simulation canonical_into_non_nullable[(10000, 100, 0.0)] 1.9 ms 2.7 ms -29.74%
Simulation canonical_into_non_nullable[(10000, 100, 0.1)] 3.7 ms 4.5 ms -18.16%
Simulation canonical_into_non_nullable[(10000, 100, 0.01)] 2.1 ms 2.9 ms -27.4%
Simulation into_canonical_non_nullable[(10000, 100, 0.1)] 3.8 ms 4.6 ms -17.65%
Simulation canonical_into_nullable[(10000, 10, 0.0)] 529.1 µs 444.1 µs +19.14%
Simulation canonical_into_nullable[(10000, 100, 0.0)] 4.9 ms 4.1 ms +19.82%
Simulation into_canonical_nullable[(10000, 100, 0.0)] 4.4 ms 5.2 ms -15.55%
Simulation into_canonical_non_nullable[(10000, 100, 0.01)] 2.2 ms 3 ms -26.83%
Simulation into_canonical_non_nullable[(10000, 100, 0.0)] 1.9 ms 2.7 ms -29.43%

Footnotes

  1. 1254 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

}
}

// WARNING check all caller if `_lower_parts` is ever supported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify this comment, and make it less Claudy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ME

| PType::U64
| PType::F16
| PType::F32
| PType::F64) => vortex_bail!("cannot convert ptpye {p} to DecimalType"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ptpye => ptype

0ax1

This comment was marked as outdated.

Copy link
Contributor

@0ax1 0ax1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 nits looks good otherwise

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) January 23, 2026 11:43
@joseph-isaacs joseph-isaacs merged commit 48742f1 into develop Jan 23, 2026
44 of 47 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/dbp-cuda branch January 23, 2026 11:53
danking pushed a commit that referenced this pull request Feb 6, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants