chore[cuda]: decimal_byte_parts#6118
Conversation
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
CodSpeed Performance ReportMerging this PR will degrade performance by 39.81%Comparing
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | u16_FoR[10M] |
11 µs | 6.4 µs | +72.15% |
| ⚡ | WallTime | u32_FoR[1K] |
7 µs | 6 µs | +16.15% |
| ❌ | WallTime | u8_FoR[10K] |
5.7 µs | 7 µs | -17.59% |
| ❌ | WallTime | u32_FoR[10K] |
6.3 µs | 7.7 µs | -18.7% |
| ❌ | WallTime | u64_FoR[10K] |
8.2 µs | 13.7 µs | -39.81% |
| ⚡ | WallTime | u8_FoR[10M] |
6.4 µs | 5.7 µs | +13.02% |
| ❌ | Simulation | canonical_into_non_nullable[(10000, 100, 0.0)] |
1.9 ms | 2.7 ms | -29.74% |
| ❌ | Simulation | canonical_into_non_nullable[(10000, 100, 0.1)] |
3.7 ms | 4.5 ms | -18.16% |
| ❌ | Simulation | canonical_into_non_nullable[(10000, 100, 0.01)] |
2.1 ms | 2.9 ms | -27.4% |
| ❌ | Simulation | into_canonical_non_nullable[(10000, 100, 0.1)] |
3.8 ms | 4.6 ms | -17.65% |
| ⚡ | Simulation | canonical_into_nullable[(10000, 10, 0.0)] |
529.1 µs | 444.1 µs | +19.14% |
| ⚡ | Simulation | canonical_into_nullable[(10000, 100, 0.0)] |
4.9 ms | 4.1 ms | +19.82% |
| ❌ | Simulation | into_canonical_nullable[(10000, 100, 0.0)] |
4.4 ms | 5.2 ms | -15.55% |
| ❌ | Simulation | into_canonical_non_nullable[(10000, 100, 0.01)] |
2.2 ms | 3 ms | -26.83% |
| ❌ | Simulation | into_canonical_non_nullable[(10000, 100, 0.0)] |
1.9 ms | 2.7 ms | -29.43% |
Footnotes
-
1254 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
| } | ||
| } | ||
|
|
||
| // WARNING check all caller if `_lower_parts` is ever supported. |
There was a problem hiding this comment.
Clarify this comment, and make it less Claudy.
vortex-dtype/src/decimal/types.rs
Outdated
| | PType::U64 | ||
| | PType::F16 | ||
| | PType::F32 | ||
| | PType::F64) => vortex_bail!("cannot convert ptpye {p} to DecimalType"), |
0ax1
left a comment
There was a problem hiding this comment.
2 nits looks good otherwise
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
No description provided.