-
Notifications
You must be signed in to change notification settings - Fork 122
Chore: Refactor FilterArray code
#6152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: ct/remove-old-filter-compute
Are you sure you want to change the base?
Chore: Refactor FilterArray code
#6152
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
CodSpeed Performance ReportMerging this PR will degrade performance by 20.02%Comparing
|
This is a mostly cosmetic change to remove the old filter compute kernels from the
FilterArrayimplementation, placing the code invortex-array/src/arrays/filter/executeinstead of dispersed everywhere. The non-cosmetic changes are trivial, just making some things cleaner to understand.This is based on top of #6147, which is also based on top of #6146