coalesced request align all segments#6158
Merged
onursatici merged 4 commits intodevelopfrom Jan 27, 2026
Merged
Conversation
onursatici
added
changelog/performance
github-actions
bot
removed
the
action/benchmark
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
CodSpeed Performance ReportMerging this PR will degrade performance by 33.22%Comparing
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: Random AccessSummary
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
vortex-file/src/read/driver.rs
Outdated
Comment on lines
209
to
210
| /// Coalesce nearby requests into a single range while aligning the range start down to the | ||
| /// maximum alignment of all included requests. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Coalesce nearby requests into a single range while aligning the range start down to the | |
| /// maximum alignment of all included requests. | |
| /// Coalesce nearby requests into a single range request aligned to widest alignment of all coalesced requests |
| /// [x, x, x, x, x, x, A, A, A, A, A, x, B] | ||
| /// A aligned to 2, B aligned to 4 | ||
| /// Coalesced range starts at 4, so the buffer is: | ||
| /// [x, x, A, A, A, A, A, x, B] |
Contributor
There was a problem hiding this comment.
why does this have 9 values in?
Contributor
Author
There was a problem hiding this comment.
you want to read both A and B, and B is only one byte in this example. It has the leading 2 byte padding to keep B 4-aligned
Signed-off-by: Onur Satici <onur@spiraldb.com>
Signed-off-by: Onur Satici <onur@spiraldb.com>
onursatici
added
action/benchmark
github-actions
bot
removed
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Signed-off-by: Onur Satici <onur@spiraldb.com>
onursatici
added
the
action/benchmark-sql
github-actions
bot
removed
the
action/benchmark-sql
joseph-isaacs
approved these changes
Jan 27, 2026
danking
pushed a commit
that referenced
this pull request
Feb 6, 2026
We align the coalesced range start down to the max alignment of all requests. That makes `coalesced_start % max_alignment == 0`, just like the file start. Because segment offsets are aligned in the file, their offsets relative to the coalesced start remain aligned, so each buffer stays properly aligned without per‑buffer realignment. example: bytes in the file: [x, x, x, x, x, x, A, A, A, A, A, x, B] A aligned to 2 B aligned to 4 coalesced read both to a 2 aligned buffer: [ A, A, A, A, A, x, B] A aligned to 2 B is not aligned to 4 with this change we read this to the coalesced buffer: [x, x, A, A, A, A, A, x, B] A aligned to 2 B aligned to 4 --------- Signed-off-by: Onur Satici <onur@spiraldb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We align the coalesced range start down to the max alignment of all requests. That makes
coalesced_start % max_alignment == 0, just like the file start. Because segment offsets are aligned in the file, their offsets relative to the coalesced start remain aligned, so each buffer stays properly aligned without per‑buffer realignment.example:
bytes in the file:
[x, x, x, x, x, x, A, A, A, A, A, x, B]
A aligned to 2
B aligned to 4
coalesced read both to a 2 aligned buffer:
[ A, A, A, A, A, x, B]
A aligned to 2
B is not aligned to 4
with this change we read this to the coalesced buffer:
[x, x, A, A, A, A, A, x, B]
A aligned to 2
B aligned to 4