Skip to content

break[expr]: remove Expression.evaluate use Array.apply(expr) instead#6167

Merged
joseph-isaacs merged 2 commits intodevelopfrom
ji/remove-expression-eval
Jan 27, 2026
Merged

break[expr]: remove Expression.evaluate use Array.apply(expr) instead#6167
joseph-isaacs merged 2 commits intodevelopfrom
ji/remove-expression-eval

Conversation

@joseph-isaacs
Copy link
Contributor

@joseph-isaacs joseph-isaacs commented Jan 27, 2026

This method was a foot gun.

@joseph-isaacs joseph-isaacs added the changelog/break A breaking API change label Jan 27, 2026
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) January 27, 2026 16:50
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs force-pushed the ji/remove-expression-eval branch from fd953ab to 3f58d64 Compare January 27, 2026 16:51
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 27, 2026

Merging this PR will degrade performance by 32.04%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 41 improved benchmarks
❌ 7 regressed benchmarks
✅ 1217 untouched benchmarks
⏩ 1219 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime u8_FoR[10M] 8.5 µs 6.2 µs +36.77%
Simulation bench_compare_varbin[(10000, 32)] 190.5 µs 170.7 µs +11.6%
Simulation bench_compare_varbin[(10000, 128)] 203.9 µs 183.6 µs +11.02%
Simulation bench_compare_varbin[(10000, 2)] 186.2 µs 166.3 µs +11.97%
Simulation bench_compare_varbin[(10000, 4)] 186.8 µs 166.8 µs +12%
Simulation bench_compare_varbin[(10000, 8)] 187.1 µs 167.2 µs +11.88%
Simulation bench_compare_varbin[(100000, 2)] 1,096.1 µs 904.1 µs +21.24%
Simulation bench_compare_varbin[(100000, 128)] 1,113 µs 920.9 µs +20.85%
Simulation bench_compare_varbin[(100000, 32)] 1,099.9 µs 908.3 µs +21.09%
Simulation bench_compare_varbinview[(10000, 128)] 203.4 µs 183.5 µs +10.89%
Simulation bench_compare_varbin[(100000, 2048)] 1.4 ms 1.2 ms +15.64%
Simulation bench_compare_varbin[(100000, 512)] 1.2 ms 1 ms +18.82%
Simulation bench_compare_varbin[(100000, 8)] 1,096.4 µs 904.9 µs +21.17%
Simulation bench_compare_varbin[(100000, 4)] 1,096.5 µs 904.4 µs +21.24%
Simulation bench_compare_varbinview[(10000, 4)] 186.5 µs 166.3 µs +12.18%
Simulation bench_compare_varbinview[(10000, 2)] 186 µs 166.3 µs +11.84%
Simulation bench_compare_varbinview[(100000, 2)] 1,095.4 µs 904.4 µs +21.12%
Simulation bench_compare_varbinview[(10000, 32)] 190.7 µs 170.2 µs +12.03%
Simulation bench_compare_varbinview[(10000, 8)] 187.1 µs 167.3 µs +11.84%
Simulation bench_compare_varbinview[(100000, 2048)] 1.4 ms 1.2 ms +15.67%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing ji/remove-expression-eval (c8f270a) with develop (39edf52)

Open in CodSpeed

Footnotes

  1. 1219 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@joseph-isaacs joseph-isaacs merged commit 176e340 into develop Jan 27, 2026
43 of 45 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/remove-expression-eval branch January 27, 2026 17:03
danking pushed a commit that referenced this pull request Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants