Skip to content

Chore: format rstest in validity tests better#6175

Merged
connortsui20 merged 1 commit intodevelopfrom
ct/rstest-validity-format
Jan 27, 2026
Merged

Chore: format rstest in validity tests better#6175
connortsui20 merged 1 commit intodevelopfrom
ct/rstest-validity-format

Conversation

@connortsui20
Copy link
Copy Markdown
Contributor

I'm just cleaning out some old branches I had lying around.

This is just a manual reformatting of the rstest cases.

@connortsui20 connortsui20 requested review from a10y and danking January 27, 2026 19:49
@connortsui20 connortsui20 added the changelog/chore A trivial change label Jan 27, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 27, 2026

Merging this PR will degrade performance by 20.08%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 11 improved benchmarks
❌ 7 regressed benchmarks
✅ 1143 untouched benchmarks
⏩ 1323 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime u8_FoR[10M] 15.4 µs 6.7 µs ×2.3
Simulation canonical_into_non_nullable[(10000, 1, 0.0)] 36 µs 24.7 µs +45.78%
Simulation canonical_into_non_nullable[(10000, 1, 0.1)] 56.9 µs 47 µs +21.12%
Simulation canonical_into_non_nullable[(10000, 10, 0.01)] 305.9 µs 221.2 µs +38.31%
Simulation canonical_into_non_nullable[(10000, 10, 0.0)] 278.7 µs 194.1 µs +43.56%
Simulation canonical_into_non_nullable[(10000, 1, 0.01)] 41 µs 31.2 µs +31.36%
Simulation canonical_into_non_nullable[(10000, 10, 0.1)] 471.5 µs 380.6 µs +23.87%
Simulation into_canonical_non_nullable[(10000, 1, 0.01)] 38.2 µs 46.2 µs -17.29%
Simulation into_canonical_non_nullable[(10000, 10, 0.0)] 283.6 µs 201.6 µs +40.69%
Simulation into_canonical_non_nullable[(10000, 10, 0.01)] 310.4 µs 229.1 µs +35.49%
Simulation into_canonical_non_nullable[(10000, 1, 0.0)] 32.2 µs 40.2 µs -20.08%
Simulation canonical_into_nullable[(10000, 100, 0.0)] 4.3 ms 5 ms -12.36%
Simulation into_canonical_non_nullable[(10000, 1, 0.1)] 54.4 µs 62.8 µs -13.39%
Simulation into_canonical_non_nullable[(10000, 10, 0.1)] 472.9 µs 385 µs +22.82%
Simulation into_canonical_nullable[(10000, 10, 0.1)] 720 µs 631.9 µs +13.94%
Simulation into_canonical_nullable[(10000, 100, 0.1)] 6.1 ms 6.9 ms -11.99%
Simulation into_canonical_nullable[(10000, 10, 0.0)] 458.8 µs 540.9 µs -15.17%
Simulation into_canonical_nullable[(10000, 100, 0.0)] 4.3 ms 5.1 ms -14.41%

Comparing ct/rstest-validity-format (2eded0d) with develop (d70a1e9)

Open in CodSpeed

Footnotes

  1. 1323 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@connortsui20
Copy link
Copy Markdown
Contributor Author

connortsui20 commented Jan 27, 2026

huh evidently this was not just a cosmetic change

Edit: oh whoops in that other branch there was some different logic

@robert3005
Copy link
Copy Markdown
Contributor

You might have a semantic merge conflict? Ie you have old base commit that had a bug that was solved

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 force-pushed the ct/rstest-validity-format branch from 0a79ee1 to 2eded0d Compare January 27, 2026 20:11
@connortsui20 connortsui20 enabled auto-merge (squash) January 27, 2026 20:12
@connortsui20 connortsui20 merged commit d27c644 into develop Jan 27, 2026
43 of 45 checks passed
@connortsui20 connortsui20 deleted the ct/rstest-validity-format branch January 27, 2026 20:19
danking pushed a commit that referenced this pull request Feb 6, 2026
I'm just cleaning out some old branches I had lying around.

This is just a manual reformatting of the rstest cases.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants