Fix: Comment on a failed benchmark#6181
Merged
connortsui20 merged 1 commit intodevelopfrom Jan 27, 2026
Merged
Conversation
5669872 to
81529a9
Compare
danking
reviewed
Jan 27, 2026
Contributor
danking
left a comment
There was a problem hiding this comment.
this seems right to me. Can we test by breaking SQL benchmarks and running them on this PR?
Contributor
Author
|
There are 2 that are already broken on develop 😢 Clickbench and Compression Throughput |
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Author
|
oh I have to do it for both actions |
81529a9 to
96ae769
Compare
Contributor
Benchmarks: Random AccessSummary
|
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
danking
approved these changes
Jan 27, 2026
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Author
|
Seems like this didn't work for the compression benchmark? |
96ae769 to
cd37859
Compare
danking
pushed a commit
that referenced
this pull request
Feb 6, 2026
Let's see if this works... Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's see if this works...