fix: evaluate OR for validity

[blaginin]

No description provided.

[cloudflare-workers-and-pages]

Deploying vortex-bench with    Cloudflare Pages

Latest commit:	f385faf
Status:	✅  Deploy successful!
Preview URL:	https://50aeb0e5.vortex-93b.pages.dev
Branch Preview URL:	https://db-kleene-or.vortex-93b.pages.dev

View logs

[joseph-isaacs]

lol

[joseph-isaacs]

can you use assert_arrays_eq!

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will degrade performance by 31.23%

_{Comparing db/kleene-or (475f085) with develop (00dabeb)}

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 7 improved benchmarks
❌ 10 regressed benchmarks
✅ 1144 untouched benchmarks
⏩ 1323 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
❌	Simulation	canonical_into_non_nullable[(10000, 1, 0.1)]	47.1 µs	57 µs	-17.33%
❌	Simulation	canonical_into_non_nullable[(10000, 1, 0.01)]	31.3 µs	41 µs	-23.73%
❌	Simulation	canonical_into_non_nullable[(10000, 10, 0.0)]	194.2 µs	278.8 µs	-30.34%
❌	Simulation	canonical_into_non_nullable[(10000, 1, 0.0)]	24.9 µs	36.2 µs	-31.23%
❌	Simulation	canonical_into_non_nullable[(10000, 10, 0.1)]	380.7 µs	471.5 µs	-19.27%
❌	Simulation	canonical_into_non_nullable[(10000, 10, 0.01)]	221.2 µs	306 µs	-27.7%
⚡	Simulation	canonical_into_nullable[(10000, 100, 0.0)]	5 ms	4.3 ms	+14.16%
⚡	Simulation	into_canonical_non_nullable[(10000, 1, 0.1)]	62.8 µs	55.2 µs	+13.77%
❌	Simulation	into_canonical_non_nullable[(10000, 10, 0.1)]	385.2 µs	473 µs	-18.57%
⚡	Simulation	into_canonical_non_nullable[(10000, 1, 0.01)]	46.3 µs	39.1 µs	+18.4%
⚡	Simulation	into_canonical_non_nullable[(10000, 1, 0.0)]	40.4 µs	33 µs	+22.45%
❌	Simulation	into_canonical_non_nullable[(10000, 10, 0.0)]	201.8 µs	283.6 µs	-28.86%
❌	Simulation	into_canonical_non_nullable[(10000, 10, 0.01)]	229.3 µs	310.6 µs	-26.16%
❌	Simulation	into_canonical_nullable[(10000, 10, 0.1)]	632.2 µs	720.2 µs	-12.22%
⚡	Simulation	into_canonical_nullable[(10000, 10, 0.0)]	541.3 µs	459.4 µs	+17.84%
⚡	Simulation	into_canonical_nullable[(10000, 100, 0.0)]	5.1 ms	4.3 ms	+16.87%
⚡	Simulation	into_canonical_nullable[(10000, 100, 0.1)]	6.9 ms	6.1 ms	+13.68%

Footnotes

1. 1323 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[joseph-isaacs]

you don't need into_array