Skip to content

chore[cuda]: fix windows#6206

Merged
joseph-isaacs merged 4 commits intodevelopfrom
ji/fixup-window-scuda
Jan 29, 2026
Merged

chore[cuda]: fix windows#6206
joseph-isaacs merged 4 commits intodevelopfrom
ji/fixup-window-scuda

Conversation

@joseph-isaacs
Copy link
Contributor

No description provided.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 29, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 21.63%

Comparing ji/fixup-window-scuda (e12f7f0) with develop (0636d8d)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 14 improved benchmarks
❌ 10 regressed benchmarks
✅ 1155 untouched benchmarks
⏩ 1323 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime 1M_50pct[500000] 55 µs 46.4 µs +18.48%
WallTime 10M_10pct[1000000] 130.6 µs 163.2 µs -19.97%
WallTime 10M_50pct[5000000] 316.3 µs 279 µs +13.39%
WallTime 1M_90pct[1000000] 87.1 µs 54 µs +61.41%
WallTime 1M_90pct[1000000] 29.2 µs 33 µs -11.44%
WallTime u64_values_u32_codes[10M] 315.7 µs 279.5 µs +12.94%
WallTime 10M_50pct[5000000] 157.5 µs 185.7 µs -15.2%
Simulation canonical_into_non_nullable[(10000, 1, 0.0)] 36 µs 24.7 µs +46.13%
Simulation canonical_into_non_nullable[(10000, 1, 0.01)] 40.9 µs 31.1 µs +31.47%
Simulation canonical_into_non_nullable[(10000, 1, 0.1)] 56.8 µs 46.9 µs +21.1%
Simulation canonical_into_non_nullable[(10000, 10, 0.0)] 278.8 µs 194 µs +43.67%
Simulation canonical_into_non_nullable[(10000, 10, 0.01)] 305.9 µs 221 µs +38.38%
Simulation canonical_into_non_nullable[(10000, 10, 0.1)] 471.4 µs 380.5 µs +23.89%
Simulation into_canonical_non_nullable[(10000, 1, 0.1)] 54.4 µs 63.7 µs -14.57%
Simulation into_canonical_non_nullable[(10000, 1, 0.01)] 38.3 µs 47.1 µs -18.76%
Simulation into_canonical_non_nullable[(10000, 1, 0.0)] 32.2 µs 41.1 µs -21.63%
Simulation canonical_into_nullable[(10000, 100, 0.0)] 4.3 ms 5 ms -12.35%
Simulation into_canonical_non_nullable[(10000, 10, 0.0)] 282.4 µs 187.5 µs +50.59%
Simulation into_canonical_non_nullable[(10000, 10, 0.1)] 471.6 µs 374.2 µs +26.03%
Simulation into_canonical_non_nullable[(10000, 10, 0.01)] 309.2 µs 215.1 µs +43.72%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Footnotes

  1. 1323 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@joseph-isaacs joseph-isaacs added the changelog/fix A bug fix label Jan 29, 2026
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) January 29, 2026 16:20
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@AdamGS AdamGS disabled auto-merge January 29, 2026 16:22
a10y
a10y previously requested changes Jan 29, 2026
Copy link
Contributor

@a10y a10y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should keep the full matcher from cargo.toml

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@AdamGS
Copy link
Contributor

AdamGS commented Jan 29, 2026

I think what's in the file (all(unix, not(target_family = "wasm"))) is redundant, if its unix its definitely not wasm

@joseph-isaacs joseph-isaacs merged commit f568de5 into develop Jan 29, 2026
45 of 47 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/fixup-window-scuda branch January 29, 2026 16:52
AdamGS pushed a commit that referenced this pull request Feb 2, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
danking pushed a commit that referenced this pull request Feb 6, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants