Skip to content

Clean up DType serde seeds#6244

Merged
gatesn merged 1 commit intodevelopfrom
ngates/serde-seeds
Feb 2, 2026
Merged

Clean up DType serde seeds#6244
gatesn merged 1 commit intodevelopfrom
ngates/serde-seeds

Conversation

@gatesn
Copy link
Copy Markdown
Contributor

@gatesn gatesn commented Feb 2, 2026

And include a test demonstrating using the seeded deserialization

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the changelog/chore A trivial change label Feb 2, 2026
@gatesn gatesn enabled auto-merge (squash) February 2, 2026 14:35
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Feb 2, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 33.09%

Comparing ngates/serde-seeds (8c95a20) with develop (6ff3d41)

Summary

❌ 1 regressed benchmark
✅ 1137 untouched benchmarks
⏩ 1384 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_into_canonical[(1000, 10)] 43 µs 64.3 µs -33.09%

Footnotes

  1. 1384 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@gatesn gatesn merged commit 76f19cb into develop Feb 2, 2026
44 of 48 checks passed
@gatesn gatesn deleted the ngates/serde-seeds branch February 2, 2026 14:44
AdamGS pushed a commit that referenced this pull request Feb 2, 2026
And include a test demonstrating using the seeded deserialization

Signed-off-by: Nicholas Gates <nick@nickgates.com>
danking pushed a commit that referenced this pull request Feb 6, 2026
And include a test demonstrating using the seeded deserialization

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants