Skip to content

More ergonomic TimestampOptions#6245

Merged
gatesn merged 2 commits intodevelopfrom
ngates/ergonomic-ts-opts
Feb 2, 2026
Merged

More ergonomic TimestampOptions#6245
gatesn merged 2 commits intodevelopfrom
ngates/ergonomic-ts-opts

Conversation

@gatesn
Copy link
Copy Markdown
Contributor

@gatesn gatesn commented Feb 2, 2026

Fixes TemporalMetadata such that matching on unit, tz is easier

@gatesn
More ergonomic TimestampOptions
190cad3 
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the changelog/chore A trivial change label Feb 2, 2026
@gatesn gatesn enabled auto-merge (squash) February 2, 2026 16:36
@gatesn gatesn requested a review from connortsui20 February 2, 2026 16:40
connortsui20
connortsui20 reviewed Feb 2, 2026
View reviewed changes
Comment thread vortex-dtype/src/datetime/matcher.rs Outdated
/// Metadata for Timestamp dtypes
Timestamp(&'a <Timestamp as ExtDTypeVTable>::Metadata),
/// Metadata for Timestamp dtypes, a tuple of time unit and optional timezone.
Timestamp((&'a crate::datetime::TimeUnit, &'a Option<Arc<str>>)),
Copy link
Copy Markdown
Contributor

@connortsui20 connortsui20 Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import?

Copy link
Copy Markdown
Contributor Author

@gatesn gatesn Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Feb 2, 2026 •
edited
Loading

Merging this PR will degrade performance by 33.04%

❌ 1 regressed benchmark
✅ 1137 untouched benchmarks
⏩ 1384 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation chunked_bool_into_canonical[(1000, 10)] 43 µs 64.3 µs -33.04%

Comparing ngates/ergonomic-ts-opts (474356c) with develop (941edaa)

Open in CodSpeed

Footnotes

  1. 1384 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

connortsui20
connortsui20 approved these changes Feb 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@connortsui20 connortsui20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@gatesn
More ergonomic TimestampOptions
474356c 
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn merged commit 65fee09 into develop Feb 2, 2026
46 of 49 checks passed
@gatesn gatesn deleted the ngates/ergonomic-ts-opts branch February 2, 2026 16:52
AdamGS pushed a commit that referenced this pull request Feb 2, 2026
@gatesn @AdamGS
More ergonomic TimestampOptions (#6245)
9535bbb 
Fixes TemporalMetadata such that matching on unit, tz is easier

Signed-off-by: Nicholas Gates <nick@nickgates.com>
danking pushed a commit that referenced this pull request Feb 6, 2026
@gatesn @danking
More ergonomic TimestampOptions (#6245)
5931861 
Fixes TemporalMetadata such that matching on unit, tz is easier

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robert3005 robert3005 robert3005 approved these changes

@connortsui20 connortsui20 connortsui20 approved these changes

Assignees

No one assigned

Labels

changelog/chore A trivial change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gatesn @robert3005 @connortsui20