select preserve validity of fields
#6260
Merged
+135
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connortsui20
added
changelog/fix
github-actions
bot
removed
the
action/benchmark
CodSpeed Performance ReportMerging this PR will improve performance by 40.65%Comparing Summary
Performance Changes
Footnotes
|
Contributor
Benchmarks: Random AccessSummary
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark Edit: seems like Github failed to download the file |
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
connortsui20
force-pushed
the
ct/select-preserve-validity
branch
from
4c302af to
1de77eb
Compare
connortsui20
commented
Feb 3, 2026
| /// - `root().a` has free fields `{a}` | ||
| /// - `root().d` has free fields `{d}` | ||
| /// - The full expression has free fields `{a, d}` (not `b`, only top-level fields are tracked) | ||
| pub fn make_free_field_annotator( |
Contributor
Author
There was a problem hiding this comment.
I can rename this back but this makes more sense to me
connortsui20
commented
Feb 3, 2026
Comment on lines
-325
to
-330
| let expr = and( | ||
| get_item("y", get_item("a", root())), | ||
| select(["a", "b"], root()), | ||
| ); | ||
| let expr = expr.optimize_recursive(&dtype).unwrap(); | ||
| let partitioned = partition(expr, &dtype, annotate_scope_access(fields)).unwrap(); |
Contributor
Author
There was a problem hiding this comment.
This test doesn't make sense since we should not be able to select over a partition.
connortsui20
commented
Feb 3, 2026
Comment on lines
-727
to
-734
| assert!( | ||
| result | ||
| .scalar_at(1) | ||
| .unwrap() | ||
| .as_struct() | ||
| .field_by_idx(0) | ||
| .unwrap() | ||
| .is_null(), |
Contributor
Author
There was a problem hiding this comment.
This test was wrong since the struct at row 1 should be null.
connortsui20
force-pushed
the
ct/select-preserve-validity
branch
from
1de77eb to
1398abd
Compare
github-actions
bot
removed
the
action/benchmark
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
robert3005
reviewed
Feb 3, 2026
Contributor
robert3005
left a comment
robert3005
left a comment
There was a problem hiding this comment.
It should move to the vtable
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/select-preserve-validity
branch
from
1398abd to
34e7693
Compare
robert3005
approved these changes
Feb 3, 2026
Contributor
Author
|
discussed offline, we wont move this to the expression vtable just yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #6255? Not sure.
This change fixes the incorrect simplification rule from
selecttopack(get_item(...)). That fix broke a few other things that made the (incorrect) assumption thatselectwould always turn intoget_items.