skip sparse array validation for device resident arrays#6315
Merged
onursatici merged 2 commits intodevelopfrom Feb 5, 2026
Merged
skip sparse array validation for device resident arrays#6315onursatici merged 2 commits intodevelopfrom
onursatici merged 2 commits intodevelopfrom
Conversation
Signed-off-by: Onur Satici <onur@spiraldb.com>
joseph-isaacs
approved these changes
Feb 5, 2026
Signed-off-by: Onur Satici <onur@spiraldb.com>
robert3005
reviewed
Feb 6, 2026
| // Verify the indices are all in the valid range | ||
| if !indices.is_empty() { | ||
| let last_index = usize::try_from(&indices.scalar_at(indices.len() - 1)?)?; | ||
| // Verify the indices are all in the valid range |
Contributor
There was a problem hiding this comment.
this is only correct if the previous thing is true
danking
pushed a commit
that referenced
this pull request
Feb 6, 2026
Signed-off-by: Onur Satici <onur@spiraldb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.