Avoid some potential stack overflow cases with deep expression trees #6321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Comment on lines
503
to
520
| while exprs.len() > 1 { | ||
| let mut next_level = Vec::with_capacity(exprs.len().div_ceil(2)); | ||
| let mut chunks = exprs.chunks_exact(2); | ||
|
|
||
| for chunk in chunks.by_ref() { | ||
| // chunk is guaranteed to have exactly 2 elements | ||
| let left = chunk[0].clone(); | ||
| let right = chunk[1].clone(); | ||
| next_level.push(combine(left, right)); | ||
| } | ||
|
|
||
| // Handle the remainder (odd element) | ||
| if let Some(last) = chunks.remainder().first() { | ||
| next_level.push(last.clone()); | ||
| } | ||
|
|
||
| exprs = next_level; | ||
| } |
Contributor
There was a problem hiding this comment.
can we do this better?
Contributor
Author
There was a problem hiding this comment.
I've personally found it inspiring
Merging this PR will not alter performance
Comparing 
Footnotes
|
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
github-actions
bot
removed
the
action/benchmark
Contributor
Benchmarks: Random AccessSummary
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
| children: impl IntoIterator<Item = Expression>, | ||
| ) -> VortexResult<Self> { | ||
| let children: Arc<[Expression]> = children.into(); | ||
| let children = Vec::from_iter(children); |
Contributor
There was a problem hiding this comment.
take a vec. otherwise a vec need to be collected here? or is there a opt around this?
Contributor
Author
There was a problem hiding this comment.
I just tried to keep the general shape of the API intact
danking
pushed a commit
that referenced
this pull request
Feb 6, 2026
…6321) Closes #6296 1. Collect large `AND`/`OR` expressions into balanced trees instead of a left/right leaning tree, making any recursion into them shorter. 2. Drop `Expression` iteratively instead of the default recursive approach. 3. Following #6251, using encoding ids instead of deep `Array::display_tree` in logs and errors. --------- Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6296
AND/ORexpressions into balanced trees instead of a left/right leaning tree, making any recursion into them shorter.Expressioniteratively instead of the default recursive approach.Array::display_treein logs and errors.