varbinview on device build skips validation#6358
Merged
onursatici merged 2 commits intodevelopfrom Feb 9, 2026
Merged
Conversation
Signed-off-by: Onur Satici <onur@spiraldb.com>
onursatici
force-pushed
the
os/vbv-device
branch
from
b96ac03 to
aa9767b
Compare
Comment on lines
+168
to
+171
| vortex_ensure!( | ||
| views_nbytes.is_multiple_of(size_of::<BinaryView>()), | ||
| "Expected views buffer length ({views_nbytes}) to be a multiple of {}", | ||
| size_of::<BinaryView>() |
Comment on lines
+108
to
+115
| if buffers.iter().any(|b| b.is_on_device()) { | ||
| return VarBinViewArray::try_new_handle( | ||
| views_handle.clone(), | ||
| Arc::from(data_handles.to_vec()), | ||
| dtype.clone(), | ||
| validity, | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
can we not always use this path?
Contributor
Author
There was a problem hiding this comment.
try_new does validation reading buffer contents
joseph-isaacs
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.