Conversation
Signed-off-by: Onur Satici <onur@spiraldb.com>
Merging this PR will degrade performance by 21.88%
Performance Changes
Comparing Footnotes
|
|
If we want to use this we should also add GPU runners to benchmarks. I think it's too early to focus on benchmarking these |
joseph-isaacs
left a comment
There was a problem hiding this comment.
Can you clean this up once its gone
|
If we have different strategies we expose, we should be able to generate benchmark data with all of those. This one is named cuda compatible but it is just a subset of encodings like the compact encodings, and I should be able to generate those and run my existing benchmark code on it. If I choose to run the query benchmark as is, it will run but will be executed on the cpu. If I have a gpu benchmark in the future, I still can use the data-gen binary to generate the files and now run on the gpu. That being said, I am happy to keep this on my branch |
Does this PR closes an open issue or discussion?
What changes are included in this PR?
allows benchmarks to create and ran against vortex-cuda files, which are vortex files that only include cuda compatible encodings
What is the rationale for this change?
How is this change tested?
Are there any user-facing changes?