Merged
Conversation
myrrc
force-pushed
the
myrrc/ffi-cpp-api-initial
branch
from
19eb3f7 to
4255eb7
Compare
Contributor
|
Oh, and def worth fully investigating the todos you brought up! |
Contributor
Author
|
show how to use `ninja` with CMake by default in the example.
Agreed
Can we do braced init, rather than the separate assignment?
I've tried, but the issue is, if you you braces/std::initialized_list,
you get compilation errors as list item is not same as vector's item
(base vs. derived), and if you cast to base type, it gets ugly.
not fully convinced this needs to be unique_ptr
Ok, agreed.
|
myrrc
force-pushed
the
myrrc/ffi-cpp-api-initial
branch
from
4255eb7 to
712e082
Compare
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
myrrc
force-pushed
the
myrrc/ffi-cpp-api-initial
branch
from
712e082 to
50aa559
Compare
github-actions
bot
removed
the
action/benchmark-sql
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Minor C++ Duckdb integration API cleanup:
i.e. const char -> const string& -> (inside SetError) string
error.cpp: don't catch extra duckdb::Exception (it's derived from std::exception)
out error pointer correctly.
check data_wrapper->wrapper before trying to lock one of its members
Also, replace raw new() allocations with make_unique + release if constructor may
throw to avoid memory leaks.