Conversation
a10y
commented
Feb 18, 2026
| if self.ops.is_empty() { | ||
| self.log(format_args!("{msg}\n{}", array.display_tree())); | ||
| } else { | ||
| self.log(msg); |
Contributor
Author
There was a problem hiding this comment.
this was taking >50% of execution time when i had logging enabled for the vortex-cuda crate, even if I didn't have it enabled for vortex-array. Mainly calculating the display_tree().
Scrapping it made the traces easier to read
Contributor
Author
|
This is helpful, but >90% of scan time is spent in ZSTD still 
|
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
a10y
force-pushed
the
aduffy/fix-gpu-scan
branch
from
b889973 to
3ed9fdf
Compare
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
a10y
force-pushed
the
aduffy/fix-gpu-scan
branch
from
2b11947 to
d0119f2
Compare
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
a10y
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Perfetto tracing generation to the CUDA scan-cli. Traces are emitted to
trace.pbwhich you can drop directly into https://ui.perfetto.dev/ and open, for example:All span + log arguments are preserved.
This PR also migrates our BP kernel to a fused FOR+BP operation. Pure BP will use reference of 0, and FOR execution will collapse the tree and fuse. This gives a noticeable boost in some of the per-batch traces of maybe ~10-20%.