perf[array]: chunked take with bounded compute graph #6589
Merged
joseph-isaacs merged 9 commits intodevelopfrom Feb 19, 2026
Merged
perf[array]: chunked take with bounded compute graph #6589joseph-isaacs merged 9 commits intodevelopfrom
joseph-isaacs merged 9 commits intodevelopfrom
Conversation
blaginin
reviewed
Feb 19, 2026
vortex/src/lib.rs
Outdated
| // Write the result to a Vortex file on disk. | ||
| let session = VortexSession::default(); | ||
| let home = std::env::var("HOME")?; | ||
| let out_path = PathBuf::from(format!("{home}/Downloads/gharchive_shuffled.vortex")); |
Member
There was a problem hiding this comment.
if you actually want this test, i can write a script that generates that arrow
Contributor
Author
There was a problem hiding this comment.
I removed for now. Might be a benchmark we should run, maybe make a issue?
robert3005
reviewed
Feb 19, 2026
blaginin
approved these changes
Feb 19, 2026
Merging this PR will not alter performance
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently take on a chunked array will create dict arrays for each contiguous indices over a chunk. Instead sort the indices to a filter on each chunk and then materalize and take the whole array
closes: #6407