chore: delete commented out metadata tests#6615
Merged
connortsui20 merged 2 commits intovortex-data:developfrom Feb 20, 2026
Merged
chore: delete commented out metadata tests#6615connortsui20 merged 2 commits intovortex-data:developfrom
connortsui20 merged 2 commits intovortex-data:developfrom
Conversation
Signed-off-by: Vignesh Sankaran <developer@sankaran.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove two commented-out test functions that reference a
check_metadatahelper that no longer exists:test_bitpacked_metadatainencodings/fastlanes/src/bitpacking/array/mod.rstest_bytebool_metadatainencodings/bytebool/src/array.rsBoth tests were fully commented out (including their
#[test]and#[cfg_attr(miri, ignore)]attributes) and referenced removed types (RkyvMetadata,SerdeMetadata). They were dead code.Testing
No behavioral change — only dead code removal.
Signed-off-by: Vignesh Sankaran developer@sankaran.io