Skip to content

Simplify ScalarFnPlugin#6687

Merged
gatesn merged 5 commits intodevelopfrom
ngates/simplify-plugin
Feb 26, 2026
Merged

Simplify ScalarFnPlugin#6687
gatesn merged 5 commits intodevelopfrom
ngates/simplify-plugin

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Feb 26, 2026

This fix got lost in my last PR, it simplifies the plugin to be a simply dyn trait, rather than requiring an implementation around a VTable. This allows us to implement logic to deserialize deprecated encodings into new encodings.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the changelog/chore A trivial change label Feb 26, 2026
@gatesn gatesn enabled auto-merge (squash) February 26, 2026 14:31
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 26, 2026

Merging this PR will degrade performance by 14.32%

❌ 1 regressed benchmark
✅ 953 untouched benchmarks
⏩ 1466 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_opt_bool_canonical_into[(10, 1000)] 1.4 ms 1.6 ms -14.32%

Comparing ngates/simplify-plugin (c12789e) with develop (afd1c36)

Open in CodSpeed

Footnotes

  1. 1466 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn merged commit 5aa738a into develop Feb 26, 2026
50 of 51 checks passed
@gatesn gatesn deleted the ngates/simplify-plugin branch February 26, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants