Implement BetweenReduceRule for ConstantArray#6695
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
Merging this PR will improve performance by 14.47%
Performance Changes
Comparing Footnotes
|
| use crate::scalar_fn::fns::between::BetweenOptions; | ||
| use crate::scalar_fn::fns::between::BetweenReduce; | ||
|
|
||
| impl BetweenReduce for ConstantVTable { |
There was a problem hiding this comment.
i thought recently there was a change/going to be a change where ConstantArray would save the scalar into a buffer. so wouldn't this break the contract of reduce rules where they don't read buffers?
There was a problem hiding this comment.
Constants will need some more special handling, for a lot of optimisations we will need the value in both cpu and gpu so we can't JUST store it in the buffer
This seems to be missing after migration and it's obviously valuable. Avoids
having to canonicalise result of between on constant array.
Signed-off-by: Robert Kruszewski github@robertk.io