Skip to content

Inline BaseArrayVTable#6697

Merged
gatesn merged 2 commits intodevelopfrom
ngates/base-vtable
Feb 26, 2026
Merged

Inline BaseArrayVTable#6697
gatesn merged 2 commits intodevelopfrom
ngates/base-vtable

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Feb 26, 2026

Inline the BaseArrayVTable to simplify array implementation.

See #6544

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn requested a review from robert3005 February 26, 2026 19:03
@gatesn gatesn added the changelog/break A breaking API change label Feb 26, 2026
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn enabled auto-merge (squash) February 26, 2026 19:04
Copy link
Contributor

@connortsui20 connortsui20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yolo

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 26, 2026

Merging this PR will degrade performance by 14.49%

⚡ 3 improved benchmarks
❌ 1 regressed benchmark
✅ 950 untouched benchmarks
⏩ 1466 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_opt_bool_canonical_into[(10, 1000)] 1.4 ms 1.6 ms -14.49%
Simulation take_map[(0.1, 1.0)] 4 ms 3.6 ms +13.58%
Simulation map_each[BufferMut<i32>, 128] 858.1 ns 770.6 ns +11.36%
Simulation bitwise_not_vortex_buffer_mut[128] 501.1 ns 442.8 ns +13.17%

Comparing ngates/base-vtable (8384a69) with develop (065f214)

Open in CodSpeed

Footnotes

  1. 1466 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@gatesn gatesn merged commit c0581d4 into develop Feb 26, 2026
49 of 50 checks passed
@gatesn gatesn deleted the ngates/base-vtable branch February 26, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants