Conversation
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
0ax1
commented
Feb 27, 2026
| .map_err(|e| vortex_err!("Failed to schedule async copy to device: {}", e))?; | ||
| } | ||
| drop(record_write); | ||
| self.memcpy_htod(host_slice, &mut cuda_slice) |
Contributor
Author
There was a problem hiding this comment.
cudarc's memcopy_htod does the event record handling under the hood.
0ax1
commented
Feb 27, 2026
| } | ||
|
|
||
| /// Schedules an async H2D memcpy from a pinned host buffer to a device slice. | ||
| pub(crate) fn memcpy_htod<H: HostSlice<u8>>( |
Contributor
Author
There was a problem hiding this comment.
We could drop the these passthrough functions by implementing deref.
0ax1
commented
Feb 27, 2026
| } | ||
|
|
||
| /// Set an optional coalesce config for this source. | ||
| pub fn with_some_coalesce_config(mut self, config: Option<CoalesceConfig>) -> Self { |
Contributor
Author
There was a problem hiding this comment.
Figured we could drop this, as it is also not used on object_store::read_at
onursatici
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.