perf: ensure that into_array is used for owned specific arrays#6795
Merged
joseph-isaacs merged 5 commits intodevelopfrom Mar 5, 2026
Merged
perf: ensure that into_array is used for owned specific arrays#6795joseph-isaacs merged 5 commits intodevelopfrom
into_array is used for owned specific arrays#6795joseph-isaacs merged 5 commits intodevelopfrom
Conversation
joseph-isaacs
changed the title
into_array is used for owned specific arrays
joseph-isaacs
commented
Mar 5, 2026
Comment on lines
+343
to
+349
| impl [<$V Array>] { | ||
| #[deprecated(note = "use `.into_array()` (owned) or `.clone().into_array()` (ref) to make clones explicit")] | ||
| pub fn to_array(&self) -> $crate::ArrayRef { | ||
| use $crate::IntoArray; | ||
| self.clone().into_array() | ||
| } | ||
| } |
Merging this PR will improve performance by 10.76%
Performance Changes
Comparing 
Footnotes
|
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
AdamGS
approved these changes
Mar 5, 2026
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: Random AccessSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pattern
ConstantArray::new(..).to_array()hides a clone, one should useinto_array.We cannot remove this form the DynArray since its required to create a ArrayRef.
This PR shadows the auto-deref
to_arrayonDynArraywith a deprecated method in the vtable macro.