Canonical::empty creates arrays directly instead of going through builders#6805
Merged
robert3005 merged 2 commits intodevelopfrom Mar 6, 2026
Merged
Canonical::empty creates arrays directly instead of going through builders#6805robert3005 merged 2 commits intodevelopfrom
robert3005 merged 2 commits intodevelopfrom
Conversation
joseph-isaacs
approved these changes
Mar 5, 2026
…lders Signed-off-by: Robert Kruszewski <github@robertk.io>
Merging this PR will improve performance by 27.35%
Performance Changes
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets rid of one more todo and avoids creating builders and array refs just to go back to canonical enum