Skip to content

Canonical::empty creates arrays directly instead of going through builders#6805

Merged
robert3005 merged 2 commits intodevelopfrom
rk/empty
Mar 6, 2026
Merged

Canonical::empty creates arrays directly instead of going through builders#6805
robert3005 merged 2 commits intodevelopfrom
rk/empty

Conversation

@robert3005
Copy link
Contributor

@robert3005 robert3005 commented Mar 5, 2026

Gets rid of one more todo and avoids creating builders and array refs just to go back to canonical enum

@robert3005 robert3005 added the changelog/performance A performance improvement label Mar 5, 2026
@robert3005 robert3005 enabled auto-merge (squash) March 5, 2026 17:08
…lders

Signed-off-by: Robert Kruszewski <github@robertk.io>
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 6, 2026

Merging this PR will improve performance by 27.35%

⚡ 3 improved benchmarks
✅ 391 untouched benchmarks
⏩ 2052 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_map[(0.1, 0.1)] 1,007.5 µs 909.4 µs +10.78%
Simulation take_map[(0.1, 0.5)] 2.6 ms 2 ms +27.35%
Simulation take_map[(0.1, 1.0)] 4.2 ms 3.5 ms +19.37%

Comparing rk/empty (58d16d4) with develop (5d6a3c8)

Open in CodSpeed

Footnotes

  1. 2052 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 merged commit dfb6478 into develop Mar 6, 2026
42 of 47 checks passed
@robert3005 robert3005 deleted the rk/empty branch March 6, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/performance A performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants