Skip to content

AggregateFn naming#6828

Merged
gatesn merged 14 commits intodevelopfrom
ngates/aggregate-fns
Mar 6, 2026
Merged

AggregateFn naming#6828
gatesn merged 14 commits intodevelopfrom
ngates/aggregate-fns

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Mar 6, 2026

Some naming fixes for the aggregate functions API

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the changelog/chore A trivial change label Mar 6, 2026
@gatesn gatesn enabled auto-merge (squash) March 6, 2026 16:49
@joseph-isaacs joseph-isaacs disabled auto-merge March 6, 2026 16:52
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 6, 2026

Merging this PR will degrade performance by 10.2%

⚡ 3 improved benchmarks
❌ 1 regressed benchmark
✅ 976 untouched benchmarks
🆕 2 new benchmarks
⏩ 1466 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_map[(0.1, 1.0)] 4.2 ms 3.6 ms +17.59%
Simulation take_map[(0.1, 0.1)] 1,007.5 µs 898.8 µs +12.1%
Simulation take_map[(0.1, 0.5)] 2.6 ms 2 ms +26.53%
🆕 Simulation sequence_decompress_u32 N/A 4.1 ms N/A
🆕 Simulation sequence_compress_u32 N/A 5.2 ms N/A
Simulation map_each[BufferMut<i32>, 128] 770.6 ns 858.1 ns -10.2%

Comparing ngates/aggregate-fns (7533b0b) with develop (5d6a3c8)2

Open in CodSpeed

Footnotes

  1. 1466 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (a8b340a) during the generation of this report, so 5d6a3c8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

gatesn added 2 commits March 6, 2026 11:57
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn merged commit 2fd4df3 into develop Mar 6, 2026
87 of 90 checks passed
@gatesn gatesn deleted the ngates/aggregate-fns branch March 6, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants