Skip to content

stop showing Fuzz action failure on success#6833

Merged
a10y merged 1 commit intodevelopfrom
ci-fuzz-fix
Mar 6, 2026
Merged

stop showing Fuzz action failure on success#6833
a10y merged 1 commit intodevelopfrom
ci-fuzz-fix

Conversation

@a10y
Copy link
Contributor

@a10y a10y commented Mar 6, 2026

Annoyingly, our Fuzz CI action always shows as failing even when it's succeeding:

image

We're checking for the wrong thing to determine if there were crashes. The artifacts dir is always created when you run the fuzzer.

We should be checking if there are any crash files in there.

Signed-off-by: Andrew Duffy <andrew@a10y.dev>
@a10y a10y marked this pull request as ready for review March 6, 2026 19:54
@a10y a10y requested review from AdamGS and connortsui20 March 6, 2026 19:55
@a10y a10y enabled auto-merge (squash) March 6, 2026 19:55
@a10y a10y added the changelog/skip Do not list PR in the changelog label Mar 6, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 6, 2026

Merging this PR will degrade performance by 11%

⚡ 7 improved benchmarks
❌ 1 regressed benchmark
✅ 972 untouched benchmarks
🆕 20 new benchmarks
⏩ 1466 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_map[(0.1, 1.0)] 4.2 ms 3.5 ms +18.64%
Simulation take_map[(0.1, 0.5)] 2.6 ms 2.1 ms +24.35%
Simulation take_map[(0.1, 0.1)] 1,007.5 µs 907.4 µs +11.04%
🆕 Simulation sequence_decompress_u32 N/A 4.1 ms N/A
🆕 Simulation sequence_compress_u32 N/A 5.2 ms N/A
Simulation take_200k_first_chunk_only 4.2 ms 3.3 ms +26.45%
Simulation patched_take_200k_first_chunk_only 5.4 ms 4.8 ms +11.98%
Simulation patched_take_200k_dispersed 5.6 ms 4.7 ms +19.84%
Simulation take_200k_dispersed 4.5 ms 3.6 ms +24.37%
🆕 Simulation decompress_utf8[(10000, 1024)] N/A 112.5 µs N/A
🆕 Simulation decompress_utf8[(1000, 16)] N/A 30.9 µs N/A
🆕 Simulation decompress_utf8[(1000, 4)] N/A 42.6 µs N/A
🆕 Simulation decompress_utf8[(10000, 16)] N/A 136 µs N/A
🆕 Simulation decompress_utf8[(1000, 256)] N/A 28.6 µs N/A
🆕 Simulation decompress_utf8[(10000, 256)] N/A 113.2 µs N/A
🆕 Simulation decompress_utf8[(100000, 1024)] N/A 946.8 µs N/A
🆕 Simulation decompress_utf8[(100000, 16)] N/A 1.2 ms N/A
🆕 Simulation decompress_utf8[(10000, 4)] N/A 209.8 µs N/A
🆕 Simulation decompress_utf8[(100000, 4096)] N/A 944.7 µs N/A
🆕 Simulation decompress_utf8[(100000, 256)] N/A 958.2 µs N/A
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing ci-fuzz-fix (a87c7e3) with develop (5d6a3c8)2

Open in CodSpeed

Footnotes

  1. 1466 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (4cbfb33) during the generation of this report, so 5d6a3c8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@a10y a10y merged commit edec459 into develop Mar 6, 2026
50 of 52 checks passed
@a10y a10y deleted the ci-fuzz-fix branch March 6, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants