Skip to content

chore: only ignore c++ diagnostics for ddb headers#6970

Merged
0ax1 merged 1 commit intodevelopfrom
ad/only-ignore-diagnostics-for-ddb-headers
Mar 16, 2026
Merged

chore: only ignore c++ diagnostics for ddb headers#6970
0ax1 merged 1 commit intodevelopfrom
ad/only-ignore-diagnostics-for-ddb-headers

Conversation

@0ax1
Copy link
Contributor

@0ax1 0ax1 commented Mar 15, 2026

DDB warnings to ignore need to be part of the DUCKDB_INCLUDES_BEGIN macro:

#define DUCKDB_INCLUDES_BEGIN                                                  \
    _Pragma("GCC diagnostic push")                                             \
    _Pragma("GCC diagnostic ignored \"-Wall\"")                                \
    _Pragma("GCC diagnostic ignored \"-Wextra\"")                              \
    _Pragma("GCC diagnostic ignored \"-Wpedantic\"")                           \
    _Pragma("GCC diagnostic ignored \"-Wunused-parameter\"")                   \
    _Pragma("GCC diagnostic ignored \"-Wtype-limits\"")
#define DUCKDB_INCLUDES_END _Pragma("GCC diagnostic pop")

Warnings originating from our own code should simply be addressed.

@0ax1 0ax1 requested a review from joseph-isaacs March 15, 2026 10:03
@0ax1 0ax1 added the changelog/chore A trivial change label Mar 15, 2026
@0ax1 0ax1 force-pushed the ad/only-ignore-diagnostics-for-ddb-headers branch from e891a5c to 302c040 Compare March 15, 2026 10:04
@0ax1 0ax1 requested a review from myrrc March 15, 2026 10:05
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 force-pushed the ad/only-ignore-diagnostics-for-ddb-headers branch from 302c040 to 5f1fb8b Compare March 15, 2026 10:05
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 15, 2026

Merging this PR will improve performance by 18.36%

⚡ 2 improved benchmarks
✅ 1007 untouched benchmarks
⏩ 1515 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bitwise_not_vortex_buffer_mut[128] 376.1 ns 317.8 ns +18.36%
Simulation bitwise_not_vortex_buffer_mut[1024] 535.6 ns 477.2 ns +12.22%

Comparing ad/only-ignore-diagnostics-for-ddb-headers (5f1fb8b) with develop (d08c89b)

Open in CodSpeed

Footnotes

  1. 1515 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@0ax1 0ax1 merged commit a67fe6e into develop Mar 16, 2026
55 checks passed
@0ax1 0ax1 deleted the ad/only-ignore-diagnostics-for-ddb-headers branch March 16, 2026 13:30
@myrrc myrrc mentioned this pull request Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants