Skip to content

feat[compat-gen]: add expected_encodings to validate fixture construction#6978

Merged
joseph-isaacs merged 3 commits intodevelopfrom
ji/expected-encoding
Mar 16, 2026
Merged

feat[compat-gen]: add expected_encodings to validate fixture construction#6978
joseph-isaacs merged 3 commits intodevelopfrom
ji/expected-encoding

Conversation

@joseph-isaacs
Copy link
Contributor

As part of the adding back-compat checks to vortex we want to ensure that the fixtures generated contain the encodings we think they do.

This add a field to each fixture checked on construction that ensure each array has that encoding

…uction

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) March 16, 2026 12:14
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 16, 2026

Merging this PR will improve performance by 18.36%

⚡ 2 improved benchmarks
✅ 1007 untouched benchmarks
⏩ 1515 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bitwise_not_vortex_buffer_mut[1024] 535.6 ns 477.2 ns +12.22%
Simulation bitwise_not_vortex_buffer_mut[128] 376.1 ns 317.8 ns +18.36%

Comparing ji/expected-encoding (ee5e0a5) with develop (01669a0)

Open in CodSpeed

Footnotes

  1. 1515 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@joseph-isaacs joseph-isaacs added the changelog/feature A new feature label Mar 16, 2026
…uction

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs requested a review from AdamGS March 16, 2026 14:30
@joseph-isaacs joseph-isaacs merged commit 074777d into develop Mar 16, 2026
54 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/expected-encoding branch March 16, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants