feat[compat-gen]: add expected_encodings to validate fixture construction#6978
Merged
joseph-isaacs merged 3 commits intodevelopfrom Mar 16, 2026
Merged
feat[compat-gen]: add expected_encodings to validate fixture construction#6978joseph-isaacs merged 3 commits intodevelopfrom
expected_encodings to validate fixture construction#6978joseph-isaacs merged 3 commits intodevelopfrom
Conversation
…uction Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Merging this PR will improve performance by 18.36%
Performance Changes
Comparing Footnotes
|
…uction Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
AdamGS
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the adding back-compat checks to vortex we want to ensure that the fixtures generated contain the encodings we think they do.
This add a field to each fixture checked on construction that ensure each array has that encoding