fix[sparse]: correctly handle cast for all-patched#6979
Merged
joseph-isaacs merged 1 commit intodevelopfrom Mar 16, 2026
Merged
fix[sparse]: correctly handle cast for all-patched#6979joseph-isaacs merged 1 commit intodevelopfrom
joseph-isaacs merged 1 commit intodevelopfrom
Conversation
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
| let casted_fill = if array.patches().num_patches() == array.len() { | ||
| // When every position is patched the fill is unused — skip casting it | ||
| // entirely and substitute a zero value for the target dtype. | ||
| Scalar::zero_value(dtype) |
Contributor
There was a problem hiding this comment.
Shouldn't this be the default value? Since it should be null if the array is nullable?
Contributor
Author
There was a problem hiding this comment.
It is undef (could be any value).
We really should never have this array. But the current executor cannot ensure that a reduce (on sparse runs before this).
Contributor
There was a problem hiding this comment.
In that case just make it default so it can fast path a null scalar here
connortsui20
approved these changes
Mar 16, 2026
Merged
connortsui20
added a commit
that referenced
this pull request
Mar 16, 2026
## Summary Followup to #6979 We should use the default value here to fast path the null, and also the comment was incorrect since casting can always fail. ## Testing N/A Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6932