Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
Contributor
|
You should also make the is_saturated check test for nans since |
gatesn
approved these changes
Mar 19, 2026
Merging this PR will degrade performance by 15.51%
Performance Changes
Comparing Footnotes
|
dimitarvdimitrov
pushed a commit
that referenced
this pull request
Mar 20, 2026
NaN will cause sum to be NaN. Instead we have NaNCount already that users can use to handle columns with NaNs. fix #5152 Signed-off-by: Robert Kruszewski <github@robertk.io> --------- Signed-off-by: Robert Kruszewski <github@robertk.io> Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-authored-by: Nicholas Gates <nick@nickgates.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NaN will cause sum to be NaN. Instead we have NaNCount already that users can
use to handle columns with NaNs.
fix #5152
Signed-off-by: Robert Kruszewski github@robertk.io