Skip to content

fix[compat]: Update the action to use the correct check command#7016

Merged
joseph-isaacs merged 7 commits intodevelopfrom
ji/fixup-compat-test
Mar 18, 2026
Merged

fix[compat]: Update the action to use the correct check command#7016
joseph-isaacs merged 7 commits intodevelopfrom
ji/fixup-compat-test

Conversation

@joseph-isaacs
Copy link
Contributor

@joseph-isaacs joseph-isaacs commented Mar 18, 2026

This adds a check to CI that ensures that files generated by the last release are still readable in this PR.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs added the changelog/fix A bug fix label Mar 18, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 18, 2026

Merging this PR will degrade performance by 10.76%

❌ 1 regressed benchmark
✅ 1008 untouched benchmarks
⏩ 1515 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_map[(0.1, 1.0)] 3.5 ms 3.9 ms -10.76%

Comparing ji/fixup-compat-test (bffa572) with develop (61bc044)

Open in CodSpeed

Footnotes

  1. 1515 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs marked this pull request as ready for review March 18, 2026 17:18
@joseph-isaacs joseph-isaacs requested review from AdamGS March 18, 2026 17:19
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) March 18, 2026 17:54
@joseph-isaacs joseph-isaacs merged commit 4fd1814 into develop Mar 18, 2026
140 of 141 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/fixup-compat-test branch March 18, 2026 18:05
dimitarvdimitrov pushed a commit that referenced this pull request Mar 20, 2026
This adds a check to CI that ensures that files generated by the last
release are still readable in this PR.

---------

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants