Skip to content

Print to stdout in compress-bench and random-access-bench #7065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connortsui20 merged 1 commit into from
Mar 19, 2026
Merged

Print to stdout in compress-bench and random-access-bench #7065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions benchmarks/compress-bench/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ use indicatif::ProgressBar;
use itertools::Itertools;
use regex::Regex;
use vortex::utils::aliases::hash_map::HashMap;
use vortex_bench::BenchmarkOutput;
use vortex_bench::Engine;
use vortex_bench::Format;
use vortex_bench::Target;
Expand All @@ -23,6 +22,7 @@ use vortex_bench::compress::Compressor;
use vortex_bench::compress::benchmark_compress;
use vortex_bench::compress::benchmark_decompress;
use vortex_bench::compress::calculate_ratios;
use vortex_bench::create_output_writer;
use vortex_bench::datasets::Dataset;
use vortex_bench::datasets::struct_list_of_ints::StructListOfInts;
use vortex_bench::datasets::taxi_data::TaxiData;
Expand Down Expand Up @@ -169,8 +169,7 @@ async fn run_compress(

progress.finish();

let output = BenchmarkOutput::with_path(BENCHMARK_ID, output_path);
let mut writer = output.create_writer()?;
let mut writer = create_output_writer(&display_format, output_path, BENCHMARK_ID)?;

match display_format {
DisplayFormat::Table => {
Expand Down
5 changes: 2 additions & 3 deletions benchmarks/random-access-bench/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ use rand::SeedableRng;
use rand::rngs::StdRng;
use rand_distr::Distribution;
use rand_distr::Exp;
use vortex_bench::BenchmarkOutput;
use vortex_bench::Engine;
use vortex_bench::Format;
use vortex_bench::Target;
use vortex_bench::create_output_writer;
use vortex_bench::datasets::feature_vectors::FeatureVectorsData;
use vortex_bench::datasets::nested_lists::NestedListsData;
use vortex_bench::datasets::nested_structs::NestedStructsData;
Expand Down Expand Up @@ -416,8 +416,7 @@ async fn run_random_access(

progress.finish();

let output = BenchmarkOutput::with_path(BENCHMARK_ID, output_path);
let mut writer = output.create_writer()?;
let mut writer = create_output_writer(&display_format, output_path, BENCHMARK_ID)?;

match display_format {
DisplayFormat::Table => {
Expand Down
Loading