fix[delta]: compress with nulls undef values use last valid value (or 0)#7124
Merged
joseph-isaacs merged 1 commit intodevelopfrom Mar 23, 2026
Merged
fix[delta]: compress with nulls undef values use last valid value (or 0)#7124joseph-isaacs merged 1 commit intodevelopfrom
joseph-isaacs merged 1 commit intodevelopfrom
Conversation
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
0ax1
reviewed
Mar 23, 2026
| use vortex_array::IntoArray; | ||
| use vortex_array::ToCanonical; | ||
|
|
||
| use crate::bitpack_compress::bitpack_encode; |
Contributor
There was a problem hiding this comment.
use crate::bitpack_compress::bitpack_encode;
use crate::delta_compress;
Move up?
0ax1
approved these changes
Mar 23, 2026
Contributor
|
Thanks @joseph-isaacs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we have undef values this can affect decompression with a undef value (use the previous valid value instead).