Skip to content

fix: remove nested block_on call in cuda_execute#7147

Merged
0ax1 merged 1 commit intodevelopfrom
ad/buffer-movement
Mar 24, 2026
Merged

fix: remove nested block_on call in cuda_execute#7147
0ax1 merged 1 commit intodevelopfrom
ad/buffer-movement

Conversation

@0ax1
Copy link
Copy Markdown
Contributor

@0ax1 0ax1 commented Mar 24, 2026

cuda_execute itself is async so we can't run a nested block_on. In the grand scheme of things, the mechanisms to allocate CUDA pinned host and device memory, as well as copying host memory to the device need to be reworked as outlined in the added TODO comment.

@0ax1 0ax1 requested a review from joseph-isaacs March 24, 2026 17:00
@0ax1 0ax1 added the changelog/fix A bug fix label Mar 24, 2026
@0ax1 0ax1 requested a review from robert3005 March 24, 2026 17:01
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 24, 2026

Merging this PR will degrade performance by 15.51%

❌ 2 regressed benchmarks
✅ 1099 untouched benchmarks
⏩ 1522 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bitwise_not_vortex_buffer_mut[128] 317.8 ns 376.1 ns -15.51%
Simulation bitwise_not_vortex_buffer_mut[1024] 477.2 ns 535.6 ns -10.89%

Comparing ad/buffer-movement (05b9a5d) with develop (cda251b)

Open in CodSpeed

Footnotes

  1. 1522 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 force-pushed the ad/buffer-movement branch from d9dd093 to 05b9a5d Compare March 24, 2026 17:09
@0ax1 0ax1 requested a review from joseph-isaacs March 24, 2026 17:14
@0ax1 0ax1 merged commit 37c01c0 into develop Mar 24, 2026
66 of 67 checks passed
@0ax1 0ax1 deleted the ad/buffer-movement branch March 24, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants